-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AC-441] Convert Hardcoded Strings to String Resources #627
Conversation
Codecov Report
@@ Coverage Diff @@
## master #627 +/- ##
=======================================
Coverage 14.29% 14.29%
=======================================
Files 202 202
Lines 9220 9220
Branches 791 791
=======================================
Hits 1318 1318
Misses 7821 7821
Partials 81 81 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hii @ribhavsharma
I have reviewed your code, looks good but can you please work on suggested changes? I've added comments on the same.
I'm not a mentor so wait for them to review it and have their say!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ribhavsharma Please follow the Pull Request Guidelines.
You need to include the JIRA ticket number in the Pull Request Name, and also have a link to it in the description.
Also, please squash your commits into a single commit.
strings fix
@vansha10 Kindly check out the PR now. |
Good work @ribhavsharma. |
Looks good @ribhavsharma. |
Looks @ribhavsharma ! Sorry for the delay. |
Description of what I changed
Converted all hardcoded strings to String Resources, so that the app can have support for multiple languages in the future.
Task that I worked on
GCI Task: Android Client: Convert Hardcoded Strings to String Resources
Issue that I worked on
AC-441
Checklist: I completed these to help reviewers :)
(the number above, next to the 'Commits' tab is 1).
existing code that was well tested you do not have to add tests)