Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AC-619: Fix window leakage error while viewing patient details #623

Merged
merged 1 commit into from
Aug 8, 2019

Conversation

deepak140596
Copy link
Contributor

@deepak140596 deepak140596 commented Aug 6, 2019

Description of what I changed

Removed the line that set TextView text to "None". Only visibility needed to be checked. The text was already set.

Issue I worked on

JIRA Issue: https://issues.openmrs.org/browse/AC-619

Checklist: I completed these to help reviewers :)

  • My pull request only contains ONE single commit
    (the number above, next to the 'Commits' tab is 1).
  • I have added tests to cover my changes. (If you refactored
    existing code that was well tested you do not have to add tests)
  • All new and existing tests passed.
  • My pull request is based on the latest changes of the master branch.

@codecov-io
Copy link

codecov-io commented Aug 6, 2019

Codecov Report

Merging #623 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #623      +/-   ##
=========================================
+ Coverage    14.3%   14.3%   +<.01%     
=========================================
  Files         202     202              
  Lines        9212    9211       -1     
  Branches      791     791              
=========================================
  Hits         1318    1318              
+ Misses       7813    7812       -1     
  Partials       81      81
Impacted Files Coverage Δ
...patientdashboard/vitals/PatientVitalsFragment.java 0% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be8c4f5...6615414. Read the comment docs.

@f4ww4z f4ww4z merged commit c16eee5 into openmrs:master Aug 8, 2019
@deepak140596 deepak140596 deleted the AC-619 branch August 8, 2019 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants