-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AC-627: Change ImageView color depending upon theme #620
Conversation
Codecov Report
@@ Coverage Diff @@
## master #620 +/- ##
=========================================
- Coverage 14.32% 14.3% -0.02%
=========================================
Files 202 202
Lines 9200 9212 +12
Branches 790 791 +1
=========================================
Hits 1318 1318
- Misses 7801 7813 +12
Partials 81 81
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @deepak140596 , just address my trivial comments.
@@ -333,4 +340,14 @@ public void onClick(View v) { | |||
break; | |||
} | |||
} | |||
|
|||
private void changeColorOfImageView() { | |||
int colorResId = R.color.green; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a good enough variable name. Also make this a final class variable instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@f4ww4z , changed the name to greenColorResId
.
openmrs-client/src/main/java/org/openmrs/mobile/activities/dashboard/DashboardFragment.java
Outdated
Show resolved
Hide resolved
@f4ww4z , Please review this PR |
Description of what I changed
Changed Tint of ImageViews in the Dashboard buttons depending on the theme set.
Issue I worked on
JIRA Issue: https://issues.openmrs.org/browse/AC-627
Checklist: I completed these to help reviewers :)
(the number above, next to the 'Commits' tab is 1).
existing code that was well tested you do not have to add tests)