Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AC-623: Name and other details are not showing when searching patients #612

Merged
merged 1 commit into from
Jul 3, 2019

Conversation

vansha10
Copy link
Contributor

Description of what I changed

In download patients, only the Patient ID was showing, now the name is also showing.

Issue I worked on

JIRA Issue: https://issues.openmrs.org/browse/AC-623

Checklist: I completed these to help reviewers :)

  • My pull request only contains ONE single commit
    (the number above, next to the 'Commits' tab is 1).
  • I have added tests to cover my changes. (If you refactored
    existing code that was well tested you do not have to add tests)
  • All new and existing tests passed.
  • My pull request is based on the latest changes of the master branch.

Screenshot:

Screenshot_20190630-155431

@codecov-io
Copy link

codecov-io commented Jun 30, 2019

Codecov Report

Merging #612 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #612      +/-   ##
==========================================
- Coverage   14.39%   14.38%   -0.01%     
==========================================
  Files         190      190              
  Lines        8823     8826       +3     
  Branches      767      768       +1     
==========================================
  Hits         1270     1270              
- Misses       7474     7477       +3     
  Partials       79       79
Impacted Files Coverage Δ
...patients/LastViewedPatientRecyclerViewAdapter.java 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2808b87...6100680. Read the comment docs.

Copy link
Collaborator

@f4ww4z f4ww4z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @vansha10 . Please also align the name and id TextViews so the right ends match, right now the name and id position doesn't look good visually.

@vansha10
Copy link
Contributor Author

vansha10 commented Jul 3, 2019

Thanks for the PR @vansha10 . Please also align the name and id TextViews so the right ends match, right now the name and id position doesn't look good visually.

@f4ww4z The name and id right ends look aligned to me. Do you mean the name and download button?

@vansha10
Copy link
Contributor Author

vansha10 commented Jul 3, 2019

Aligned name and download button.
Screenshot_20190703-193229

@f4ww4z
Copy link
Collaborator

f4ww4z commented Jul 3, 2019

@f4ww4z The name and id right ends look aligned to me. Do you mean the name and download button?

Yes sorry, I do mean the name and download button.

Looks good @vansha10 !

@f4ww4z f4ww4z merged commit 5ab7c0d into openmrs:master Jul 3, 2019
@vansha10 vansha10 deleted the AC623 branch November 24, 2019 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants