AC-622: Add, Edit,Delete Providers

[deepak140596]

Description of what I changed

Added Swipe Option menu to delete and edit providers.
Added FAB to add providers.
Created ProviderRepository with Callback.
Created Activity to add and edit providers.

Issue I worked on

JIRA Issue: https://issues.openmrs.org/browse/AC-622

Checklist: I completed these to help reviewers :)

• My pull request only contains ONE single commit
  (the number above, next to the 'Commits' tab is 1).

• I have added tests to cover my changes. (If you refactored
  existing code that was well tested you do not have to add tests)

• All new and existing tests passed.

• My pull request is based on the latest changes of the master branch.

[codecov-io]

Codecov Report

Merging #611 into master will decrease coverage by 0.07%.
The diff coverage is 8.94%.

@@            Coverage Diff             @@
##           master     #611      +/-   ##
==========================================
- Coverage   14.39%   14.31%   -0.08%     
==========================================
  Files         190      194       +4     
  Lines        8823     9025     +202     
  Branches      767      784      +17     
==========================================
+ Hits         1270     1292      +22     
- Misses       7474     7654     +180     
  Partials       79       79

Impacted Files	Coverage Δ
...openmrs/mobile/utilities/ApplicationConstants.java	0% <0%> (ø)	⬆️
...mobile/activities/dashboard/DashboardFragment.java	0% <0%> (ø)	⬆️
...gerdashboard/ProviderManagerDashboardActivity.java	0% <0%> (ø)
...agerdashboard/addprovider/AddProviderActivity.java	0% <0%> (ø)
...agerdashboard/addprovider/AddProviderFragment.java	0% <0%> (ø)
...agerdashboard/addprovider/AddProviderContract.java	0% <0%> (ø)
...d/ProviderManagerDashboardRecyclerViewAdapter.java	0% <0%> (ø)
...gerdashboard/ProviderManagerDashboardFragment.java	0% <0%> (ø)
...penmrs/mobile/api/retrofit/ProviderRepository.java	18.75% <2.08%> (-49.68%)	⬇️
...erdashboard/ProviderManagerDashboardPresenter.java	38.7% <7.14%> (ø)
... and 7 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2808b87...4e30368. Read the comment docs.

[deepak140596]

@f4ww4z, made the PR. Please review it.

[f4ww4z]

Thanks @deepak140596 , please address my comments.

Also, what is meant by the toast message at the above image? Can you change it to a phrase?

[deepak140596]

@f4ww4z , now Edit , Delete and Adding Providers are working.

[f4ww4z]

The UI for all of this looks great! @deepak140596 do address all my comments:

• For AddProvider screen, it needs to be following the MVP pattern still, don't put all the code into 1 big class.
• To sort these screens out (the 'provider manager dashboard' and the 'add provider' screens), I suggest you rename the providermanager to providermanagerdashboard and all the classes inside it to follow the ProviderManagerDashboard name. Then, create the addprovider package and work on the 'add provider' screen inside it.
• Change provider_manager in strings.xml to Provider Manager.

[f4ww4z]

Did you try accessing the given, middle and family names using getNames ?

[deepak140596]

Yes. It always shows the size as 0. I think there is some problem in the backend where the names are store in Display and are lost in the List variable.

[f4ww4z]

@deepak140596 Can you investigate this and file a new issue?

[f4ww4z]

What is being done here? This complexity is too high.

[deepak140596]

It extracts the first and last names of the Provider. I have broken this line into two parts.

[f4ww4z]

Why did you choose to create this method? You can possibly rename this to createPersonFromUserInput.

[f4ww4z]

1 more thing: make sure to add tests to the Presenter of 'add providers' screen, at least.

[f4ww4z]

Looks good @deepak140596 !