-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AC-620: Make UI more consistent #607
Conversation
@@ -48,7 +48,7 @@ public ActiveVisitsRecyclerViewAdapter(Context context, List<Visit> items) { | |||
@NonNull |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refactored name and Formatted using AS
@@ -39,9 +39,10 @@ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refactored name and formatted using AS
@@ -32,6 +32,7 @@ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refactored name and formatted using AS
@@ -43,6 +43,7 @@ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refactored name and formatted using AS
@@ -38,7 +38,7 @@ | |||
import androidx.core.content.ContextCompat; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refactored name and formatted using AS
} | ||
} | ||
|
||
public void setBackdropImage(Bitmap backdropImage, String patientName) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Setting backdrop image and its click action
@@ -44,7 +44,7 @@ public PatientVisitsRecyclerViewAdapter(PatientVisitsFragment context, List<Visi | |||
@NonNull |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refactored name and formatted using AS
@@ -76,7 +76,7 @@ public SyncedPatientsRecyclerViewAdapter(SyncedPatientsFragment context, List<Pa | |||
@NonNull | |||
@Override | |||
public SyncedPatientsRecyclerViewAdapter.PatientViewHolder onCreateViewHolder(@NonNull ViewGroup parent, int viewType) { | |||
View itemView = LayoutInflater.from(parent.getContext()).inflate(R.layout.find_synced_patients_row, parent, false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refactored name and formatted using AS
@@ -32,7 +32,7 @@ public OpenMRSInflater(LayoutInflater inflater) { | |||
} | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refactored name and formatted using AS
d6597db
to
483802e
Compare
Codecov Report
@@ Coverage Diff @@
## master #607 +/- ##
==========================================
- Coverage 14.39% 14.38% -0.02%
==========================================
Files 184 184
Lines 8558 8565 +7
Branches 746 746
==========================================
Hits 1232 1232
- Misses 7249 7256 +7
Partials 77 77
Continue to review full report at Codecov.
|
Looks good @deepak140596 ! Tested locally. |
Description of what I changed
Issue I worked on
JIRA Issue: https://issues.openmrs.org/browse/AC-620
Checklist: I completed these to help reviewers :)
(the number above, next to the 'Commits' tab is 1).
existing code that was well tested you do not have to add tests)