-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AC-618: Revamp Settings Page #604
Conversation
Codecov Report
@@ Coverage Diff @@
## master #604 +/- ##
==========================================
+ Coverage 14.36% 14.39% +0.03%
==========================================
Files 185 184 -1
Lines 8575 8556 -19
Branches 751 746 -5
==========================================
Hits 1232 1232
+ Misses 7266 7247 -19
Partials 77 77
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @deepak140596 , please address my comments.
openmrs-client/src/main/java/org/openmrs/mobile/activities/settings/SettingsFragment.java
Outdated
Show resolved
Hide resolved
openmrs-client/src/main/java/org/openmrs/mobile/activities/settings/SettingsFragment.java
Outdated
Show resolved
Hide resolved
e4b44ba
to
cf97ba4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got some more comments after testing thoroughly.
Description of what I changed
Issue I worked on
JIRA Issue: https://issues.openmrs.org/browse/AC-618
Checklist: I completed these to help reviewers :)
(the number above, next to the 'Commits' tab is 1).
existing code that was well tested you do not have to add tests)