Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AC-618: Revamp Settings Page #604

Merged
merged 1 commit into from
Jun 10, 2019
Merged

AC-618: Revamp Settings Page #604

merged 1 commit into from
Jun 10, 2019

Conversation

deepak140596
Copy link
Contributor

@deepak140596 deepak140596 commented Jun 6, 2019

Description of what I changed

  • Removed Recycler view for inflating settings rows
  • Configured and used ConstraintLayout
  • Less lines will be needed to add a new settings to page
  • Used Material design for settings.
  • Added Rate Us feature to rate the app on Playstore

Issue I worked on

JIRA Issue: https://issues.openmrs.org/browse/AC-618

Checklist: I completed these to help reviewers :)

  • My pull request only contains ONE single commit
    (the number above, next to the 'Commits' tab is 1).
  • I have added tests to cover my changes. (If you refactored
    existing code that was well tested you do not have to add tests)
  • All new and existing tests passed.
  • My pull request is based on the latest changes of the master branch.

@codecov-io
Copy link

codecov-io commented Jun 7, 2019

Codecov Report

Merging #604 into master will increase coverage by 0.03%.
The diff coverage is 4.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #604      +/-   ##
==========================================
+ Coverage   14.36%   14.39%   +0.03%     
==========================================
  Files         185      184       -1     
  Lines        8575     8556      -19     
  Branches      751      746       -5     
==========================================
  Hits         1232     1232              
+ Misses       7266     7247      -19     
  Partials       77       77
Impacted Files Coverage Δ
...openmrs/mobile/utilities/ApplicationConstants.java 0% <ø> (ø) ⬆️
...s/mobile/activities/settings/SettingsFragment.java 0% <0%> (ø) ⬆️
.../mobile/activities/settings/SettingsPresenter.java 76.47% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f6ab25...3b1c846. Read the comment docs.

@deepak140596
Copy link
Contributor Author

Screenshot_20190607-143702

Copy link
Collaborator

@f4ww4z f4ww4z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @deepak140596 , please address my comments.

@deepak140596 deepak140596 force-pushed the AC-618 branch 2 times, most recently from e4b44ba to cf97ba4 Compare June 9, 2019 10:23
Copy link
Collaborator

@f4ww4z f4ww4z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got some more comments after testing thoroughly.

@f4ww4z f4ww4z merged commit c21a940 into openmrs:master Jun 10, 2019
@deepak140596 deepak140596 deleted the AC-618 branch June 11, 2019 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants