Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AC-607: Replace Apache HTTP API Client library #592

Merged
merged 1 commit into from
Jun 4, 2019

Conversation

deepak140596
Copy link
Contributor

Description of what I changed

Removed deprecated Apache HTTP API Client library from build.gradle (app level).

Issue I worked on

JIRA Issue: https://issues.openmrs.org/browse/AC-607

Checklist: I completed these to help reviewers :)

  • My pull request only contains ONE single commit
    (the number above, next to the 'Commits' tab is 1).
  • I have added tests to cover my changes. (If you refactored
    existing code that was well tested you do not have to add tests)
  • All new and existing tests passed.
  • My pull request is based on the latest changes of the master branch.

@codecov-io
Copy link

codecov-io commented May 29, 2019

Codecov Report

Merging #592 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #592   +/-   ##
=======================================
  Coverage   14.16%   14.16%           
=======================================
  Files         184      184           
  Lines        8557     8557           
  Branches      750      750           
=======================================
  Hits         1212     1212           
  Misses       7270     7270           
  Partials       75       75

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e85180...60f34f6. Read the comment docs.

Copy link
Collaborator

@f4ww4z f4ww4z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @deepak140596 , will merge after 2.7.2 is released. Our priority currently is AC-613, can you take a look into it if you have time?

@f4ww4z f4ww4z merged commit d23c576 into openmrs:master Jun 4, 2019
@deepak140596 deepak140596 deleted the AC-607 branch June 11, 2019 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants