Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: add issue-specification-document #59

Merged
merged 7 commits into from
Jul 6, 2023
Merged

Conversation

PolarishT
Copy link
Contributor


  • [✅] My pull request adheres to the code style of this project
  • [✅] My code requires changes to the documentation
  • [✅] I have updated the documentation as required
  • [✅] All the tests have passed

🅰 Which issue(s) this PR fixes:

Fixes #42

📝 Special notes for your reviewer:

🎯 Describe how to verify it

📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.:

PolarishT and others added 3 commits July 4, 2023 23:44
Signed-off-by: SgitBusity <72297937+AllianceTing@users.noreply.github.com>
Signed-off-by: AllianceTing <2426446427@qq.com>
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 5, 2023
@PolarishT PolarishT closed this Jul 5, 2023
@PolarishT PolarishT reopened this Jul 5, 2023
@PolarishT PolarishT changed the title Feat/name Docs: add issue-specification-document Jul 5, 2023
Signed-off-by: AllianceTing <2426446427@qq.com>
@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 5, 2023
it. For new feature suggestions, indicate the changes you want and the expected behavior.

## **for commiter**

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo, should be committer

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix it already

## **for commiter**

##### **working for pr/mr**

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pr only, this is not gitlab we don't have mr

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix it already

*progress**(进度 such as running,later),**size**(问题规模 such as L,M,XXL))

##### **claim issue and meke pr**

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix it already

# issue specification

- we use [lot issues] (https://github.com/openIMSDK/openKF/issues) before reporting bugs, Please make sure that has been
searching similar [question] (https://github.com/OpenIMSDK/OpenKF/issues), because they may have already answered or
Copy link
Contributor

@charles-chenzz charles-chenzz Jul 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the link didn't embed
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe document is not compatible, i will check it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

already fix it

@charles-chenzz
Copy link
Contributor

btw the commit message should not contain info like issues, most likely it will make people confuse
image

Signed-off-by: SgitBusity <72297937+AllianceTing@users.noreply.github.com>
@PolarishT PolarishT self-assigned this Jul 5, 2023
Signed-off-by: SgitBusity <72297937+AllianceTing@users.noreply.github.com>
@cubxxw cubxxw merged commit 4ad25e7 into openimsdk:main Jul 6, 2023
1 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: developers issue specification
3 participants