autoconf Dependency Fix #1764
autoconf Dependency Fix #1764
Conversation
Signed-off-by: jcsiadal <jeremy.c.siadal@intel.com>
| %if 0%{?suse_version} || 0%{?sle_version} | ||
| Requires: perl-base | ||
| %else | ||
| Requires: perl-interpreter |
There was a problem hiding this comment.
The perl-base or perl-interpreter explicit dependency seems unnecessary. perl(File::Compare) pulls in those packages on each platform already.
There was a problem hiding this comment.
I looked through the dependency chain and it doesn't appear that RHEL's perl-file-compare will install the perl binary. I also looked at the Fedora autoconf specfile and they explicitly add perl-interpreter. The SUSE one isn't needed, but I wanted to keep things parallel.
There was a problem hiding this comment.
If I do dnf -y install "perl(File::Compare)" perl-interpreter is pulled in on 9.1.
There was a problem hiding this comment.
"you SHOULD NOT assume any other packages are present as RPM dependencies and anything brought into the buildroot by the build system can change over time."
That's from Red Hat's packaging guidelines. They do say that one can usually drop Requires: if we're running autorequires, but I thought we're only doing manual deps. The other question to ask: if it's not needed, why does Fedora include it in their autoconf spec?
|
|
||
| %install | ||
| make %{?_smp_mflags} DESTDIR=$RPM_BUILD_ROOT install | ||
|
|
||
| # remove share/info/dir to avoid conflict with other package installs | ||
| rm -f $RPM_BUILD_ROOT/%{install_path}/share/info/dir | ||
|
|
||
| %{__mkdir_p} ${RPM_BUILD_ROOT}/%{_docdir} | ||
| mkdir -p ${RPM_BUILD_ROOT}/%{_docdir} |
There was a problem hiding this comment.
I'm surprised you would ask. Red Hat's RPM guide (at least one of them) says not to use (LSB) shell command macros. They were put in to make RPM portable across OSs (like Windows or BSD) and that never happened. They're just extra work with no benefit. SUSE says to never use them.
When I touch an RPM spec, I try and clean it up to current RPM standards, i.e. both RH and SUSE mandate %license now.
If you want to make formatting changes please add them to separate commits and do not mix functional changes with formatting changes. |
|
A friendly reminder that this PR had no activity for 30 days. |
Fixes missing install dependencies.
Also made some formatting changes to the specfile.