Match spack-ohpc dependencies to published system requirements #1365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Missed the signoff instructions at first, we'll get those fixed before marking ready for review. |
Without these additional "Requires", Spack lacks full functionality. In particular, gcc and gcc-c++ are needed to correctly build packages installed through Spack. Therefore, the installation of Spack should require these. Signed-off-by: Kerley <sw-arkerley@tntech.edu>
Signed-off-by: Kerley <sw-arkerley@tntech.edu>
juleskerley
force-pushed
the
Patch_Additional_Requires
branch
from
8826f4a
to
6eb4233
Compare
|
I think this is missing
|
The xz is supposed to be in there. I must have somehow looked over it. I will quickly correct that. |
added 2 commits
October 14, 2021 10:26
Signed-off-by: Kerley <sw-arkerley@tntech.edu>
Signed-off-by: Kerley <sw-arkerley@tntech.edu>
mikerenfro
changed the title
koomie
pushed a commit
that referenced
this pull request
Nov 14, 2021
Signed-off-by: Karl W. Schulz <karl.oden.utexas.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From discussion with @adrianreber on Slack this morning, we noticed on a fresh install of OHPC with Spack, that we were unable to run some
spack installcommands out of the box, due to us not yet havingg++installed, nor had we runspack compiler findafter installing OHPC-packaged compilers to fix root'scompilers.yaml.This PR ensures all the system prerequisites are dependencies of the Spack package. It may not provide optimized compilations, but should work better out of the box.