This repository has been archived by the owner on May 17, 2021. It is now read-only.
Fixed javascript that was breaking the colorpicker. #4021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this contribution @9037568! Could you please also contribute this fix to ESH? Will keep this PR open until the according change (please refer to this PR) has been merged. Thanks in advance … |
|
Created new PR in ESH (#1024). |
|
great, thanks @9037568! |
teichsta
added a commit
that referenced
this pull request
Feb 13, 2016
Fixed javascript that was breaking the colorpicker.
|
Thanks a lot @9037568 for going through the formalities!! Also cherry-picked into 1.8 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #3864.
The code was rendering this javascript, which breaks the statement because of the double quotes in the span:
<img src="/images/colorwheel.png" width="29" height="29" border="0"
onclick="OH.colorpicker.setup('Fireplace', 'Chris' Fireplace <span style="">Err', '#ffffff')" />
This patch changes the double quotes to escaped single quotes.