Skip to content
This repository has been archived by the owner on May 7, 2020. It is now read-only.

Fixed javascript that was breaking the colorpicker. #1024

Merged
merged 1 commit into from
Feb 13, 2016

Conversation

9037568
Copy link
Contributor

@9037568 9037568 commented Feb 12, 2016

Added to esh per request from @teichsta. See PR openhab/openhab1-addons#4021.

@kaikreuzer
Copy link
Contributor

@9037568 Please note that you need a CLA and to sign-off your commits, see https://github.com/eclipse/smarthome/blob/master/CONTRIBUTING.md for details.

@9037568
Copy link
Contributor Author

9037568 commented Feb 12, 2016

Could someone please make it harder to submit a one-line code change?
That'd be great.

I submitted a CLA. Do I need to do anything else to finish this out?

@kaikreuzer
Copy link
Contributor

Could someone please make it harder to submit a one-line code change?

My hope would be that you will do further contributions in future and this is a one time effort only.
The other option is to ask somebody else to do the code change.

Do I need to do anything else to finish this out?

Yes, you need to sign off your commit.

Added to esh per request from @teichsta. See PR eclipse-archived#4021.

Signed-off-by: Chris Carman <namraccr@gmail.com>
@9037568
Copy link
Contributor Author

9037568 commented Feb 13, 2016

Ok, I think I've got the sign-off done. Let me know if this is incorrect?

@kaikreuzer
Copy link
Contributor

Well, done! Thank you for going through the formalities - the next contribution will be easier :-)

kaikreuzer added a commit that referenced this pull request Feb 13, 2016
Fixed javascript that was breaking the colorpicker.
@kaikreuzer kaikreuzer merged commit 3c0e7c9 into eclipse-archived:master Feb 13, 2016
@kaikreuzer kaikreuzer modified the milestone: 0.8.0.b5 May 22, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants