Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't handle xml files 2 times #845

Merged
merged 2 commits into from
Nov 30, 2023
Merged

Conversation

domi4484
Copy link
Member

They are already handled by FileDropListView.ValidExtenstions

Fix #837

They are already handled by FileDropListView.ValidExtenstions

Fix #837
@signedav
Copy link
Member

Now I get it, what is happening here. Thanks for this PR.

We only want to open our dialog on the extensions ["xtf", "XTF", "itf", "ITF", "ili"] and not on XML, xml - that's why this list additional_xml_files has been introduced. But I broke the behavior by checking FileDropListView.ValidExtenstions.

So the problem is not that additional_xml_files is existing but that FileDropListView.ValidExtenstions contains also xml, XML

So the solution would be:

Can you do it or - if you are busy - I can do it, since I know now what it is about.

@domi4484 domi4484 force-pushed the fixDoubleXMLInDroppedFilesList branch from ea8e763 to ef6221f Compare November 30, 2023 07:46
Copy link
Member

@signedav signedav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good. Thanks.

@domi4484
Copy link
Member Author

I could only test drops in the main QGIS windows, as the wizard dialog disappears for me when clicking outside in the file manager (maybe a KDE thisg?).

In the main window behaviour is following:

  • Drop accepted for xtf, itf, ili
  • Drop discarded for xml, ini, toml

In the wizard (untested):

  • Drop accepted for xtf, itf, ili, xml, ini, toml

@signedav
Copy link
Member

signedav commented Nov 30, 2023

But when you drop xtf, itf, ili, xml, ini, toml in the main window all are accepted, right? (because at least one INTERLIS file)

@signedav
Copy link
Member

(maybe a KDE thisg?).

Maybe yes...

@domi4484
Copy link
Member Author

But when you drop xtf, itf, ili, xml, ini, toml in the main window all are accepted, right? (because at least one INTERLIS file)

Exactly, if at least one xtf, itf, ili is in the list, then all are accepted

@domi4484 domi4484 merged commit 7749b69 into master Nov 30, 2023
6 checks passed
@domi4484 domi4484 deleted the fixDoubleXMLInDroppedFilesList branch November 30, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle Import Files lists multiple times the same file
2 participants