feat: adds superset docker services and open edx integrations #1
Conversation
pomegranited
force-pushed
the
jill/install-superset
branch
from
99cddf7
to
7ea7213
Compare
tutorsuperset/plugin.py
Outdated
| OPENEDX_COURSES_LIST_URL: {{ SUPERSET_OPENEDX_COURSES_LIST_URL }} | ||
| SECRET_KEY: {{ SUPERSET_SECRET_KEY }} | ||
| PYTHONPATH: /app/pythonpath:/app/docker/pythonpath_dev | ||
| REDIS_HOST: superset_cache |
There was a problem hiding this comment.
I think you asked this elsewhere, but it would be cool if we could use the same redis as LMS for sure
There was a problem hiding this comment.
Was easy to do once I figured out the right init scripts! This is now using Open edX's redis for caching, and MySQL for the backend database instead of postgres.
There was a problem hiding this comment.
Overall this is great, and I am hoping folks can use it to work with permissions while we work on getting ClickHouse set up. I think I documented the few issues I ran into, most of which were my own fault.
One other random things is that I have a tutor_nightly_dev-superset-1 container which is always in "restarting" state. No idea what I may have done to cause that, but just want to make sure you don't see the same thing.
Not something for this PR, but just to be aware of - based on some of the use cases from the community my next round of thoughts on permissions and dashboards are here: openedx/openedx-aspects#28
I'd be happy to thumb this if the docs get updated and examples removed, then we can use it a little more easily as grounds for further investigation!
* install custom requirements for mysql and OAuth2 * install custom oauth2 manager and course permissions plugin, which uses the Open edX mysql db to fetch user staff/superuser status * init OAuth2 application on LMS * replaces deprecated Tutor init commands with latest version
Also: * After Open edX SSO is enabled, there's no way to login as the Superset Admin user, so there's no need to create one. * pins superset version
instead of superset's own redis + postgres. Also: * use redis for all superset caches * tweaks some comments, nothing huge
pomegranited
force-pushed
the
jill/install-superset
branch
from
7fc7afc
to
c4ac262
Compare
|
@bmtcril I believe I've addressed all the bugs you raised, and the wishlist items:
This was caused by an unnecessary service I had wrapping all the superset services. It's been removed now, so you shouldn't see this anymore (though you may have to fully stop Tutor and relaunch).
Yep yep, I'll address those with my next PR.
Done! Thanks for your approval! I'm going to merge this, and will iterate with the next issue. |
This plugin runs Superset in Tutor, with the following customizations:
Testing instructions
See updated README.rst
Author Notes & Concerns
A: Yes
I tried this, but wasn't able to work out how to get superset's db migrations working.