Skip to content

Commit

Permalink
rtw89: Remove redundant check of ret after call to rtw89_mac_enable_b…
Browse files Browse the repository at this point in the history
…b_rf

The function rtw89_mac_enable_bb_rf is a void return type, so there is
no return error code to ret, so the following check for an error in ret
is redundant dead code and can be removed.

Addresses-Coverity: ("Logically dead code")
Fixes: e3ec701 ("rtw89: add Realtek 802.11ax driver")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Ping-Ke Shih <pkshih@realtek.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20211015152113.33179-1-colin.king@canonical.com
  • Loading branch information
Colin Ian King authored and Kalle Valo committed Oct 18, 2021
1 parent c51ed74 commit f7e7e44
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions drivers/net/wireless/realtek/rtw89/mac.c
Original file line number Diff line number Diff line change
Expand Up @@ -2656,8 +2656,6 @@ int rtw89_mac_init(struct rtw89_dev *rtwdev)
goto fail;

rtw89_mac_enable_bb_rf(rtwdev);
if (ret)
goto fail;

ret = rtw89_mac_sys_init(rtwdev);
if (ret)
Expand Down

0 comments on commit f7e7e44

Please sign in to comment.