Use symfony/http-client #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
force-pushed
the
symfony-http-client
branch
from
3db9926
to
9e68c37
Compare
|
Currently working in a different project, so I won't have time to review openai-php/client#65 for the next couple days. Maybe we can adjust this pull request, to ship with Guzzle for now? |
|
At the current state of the main branch, the bundle is working using guzzle. It can be tagged. This PR is an improvement for a better integration with Symfony toolchain. |
This comment was marked as resolved.
This comment was marked as resolved.
|
openai-php/client v0.4.0 has been released which removes the guzzle dependency and allows for a custom HTTP client: openai-php/client@v0.3.5...v0.4.0#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R51 |
|
cc @GromNaN |
GromNaN
force-pushed
the
symfony-http-client
branch
from
9e68c37
to
ecf6173
Compare
|
Thank you for the update. This PR is ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a better integration with Symfony and the profiler panel,
symfony/http-clientshould be used.That is now possible thanks to openai-php/client#75