Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR unifies the exception handling between the different request types and HTTP client implementations:
ErrorException
like object or content requests already do.ClientException
s are checked for json errors before throwing theTransporterException
and throw aErrorException
instead.Background: For client errors (4xx) the API returns a json error but this wasn't handled with the Guzzle Client yet because Guzzle throws an exception instead of returning the response like the other HTTP clients do.
This change from
TransporterException
toErrorException
for 4xx responses with the Guzzle Client is a (minor) breaking change!This resolves #90