Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in when reconstructing a 3D field from thetaMode data #344

Merged
merged 1 commit into from
Jul 28, 2022

Conversation

AngelFP
Copy link
Member

@AngelFP AngelFP commented Jul 19, 2022

In #337, a bug was introduced that causes the 3D reconstruction to fail if Nr > max_res_transv/2. This is because Nr is no longer being updated after reducing the radial resolution of the Fcirc array. This PR adds back the lines of code that were updating this value.

@AngelFP
Copy link
Member Author

AngelFP commented Jul 20, 2022

Somehow the Windows tests have failed, but it does not seem to be related to the changes in this PR. It cannot find the openPMD test data (RuntimeError: Found no valid files in directory ./example-2d/hdf5/.)

@ax3l ax3l self-requested a review July 26, 2022 00:05
@ax3l ax3l added the bug label Jul 26, 2022
@ax3l ax3l self-assigned this Jul 26, 2022
@ax3l ax3l requested a review from RTSandberg July 26, 2022 00:07
@ax3l
Copy link
Member

ax3l commented Jul 26, 2022

CI:

Collecting openpmd-api
  Downloading openPMD_api-0.14.5-cp39-cp39-win_amd64.whl (1.7 MB)
     ---------------------------------------- 1.7/1.7 MB 36.2 MB/s eta 0:00:00
...
Please check that this is the path to the openPMD files.(valid files must have one of the following extensions: ['json', 'bp'])

Means that my latest wheel build (openPMD/openPMD-api#1286) for Windows did not compile-in HDF5 properly. Will fix: openPMD/openPMD-api#1305

@AngelFP
Copy link
Member Author

AngelFP commented Jul 26, 2022

Thanks for having a look at it!

Copy link
Contributor

@RTSandberg RTSandberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching and fixing this!

@ax3l
Copy link
Member

ax3l commented Jul 28, 2022

With openPMD/openPMD-api#1305 merged, Windows pip HDF5 should work again 🎉 I'll restart CI for it.

@ax3l ax3l merged commit 542e113 into openPMD:dev Jul 28, 2022
@AngelFP
Copy link
Member Author

AngelFP commented Aug 12, 2022

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants