3d from circ interp #311
Merged
3d from circ interp #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
presently the method
construct_3d_from_circgets field value at(x_i, y_i)from the upper cell noder_i.In some case this may provide a lower accuracy, e.g. in some particular cases the full integral of laser
Ex**2field could differ by up to a few percents from its real value (calculated on the actual cylindrical grid).This PR adds a linear interpolation to this method and increases the accuracy. For example, in the default example
lwfa_script.pymodified withNr = 350andNz = 1800the discrepancy in the total laser energy estimate is decreased from 0.054% to 0.002%.