build: add puppeteer #685
Closed
build: add puppeteer #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
build error due to timeout |
|
@abhaychawla should I merge? |
karantakalkar
added
the
review requested
|
Closing as this is subject to discussion |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
karma.conf.jsis found but fails atrequire('puppeteer')as it is not included as a dependency (npm install does not add it), Karma's error handler gives outMODULE_NOT_FOUNDerror somewhat similar to karma-runner/karma#3339.puppeteer documentation: (see bottom) https://github.com/karma-runner/karma-chrome-launcher
karma documentation: http://karma-runner.github.io/4.0/config/configuration-file.html
Related issues and discussion
#684
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
If you have multiple commits please combine them into one commit by squashing them.
Read and understood the contribution guidelines at
web-app/.github/CONTRIBUTING.md.