Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update countries.yaml #348

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Conversation

sandrinecharousset
Copy link
Collaborator

changed iso2 code of norway from NO to 'NO' because python yaml understood NO as False, not as a 2 characters string

changed iso2 code of norway from NO to 'NO' because python yaml understood NO as False, not as a 2 characters string
@sandrinecharousset
Copy link
Collaborator Author

I am using this file in one of my scripts for plan4res and I couldn't get the iso2 code for norway, it was replaced by False...... Maybe there is a better solution but I am not a python nor yaml expert..... @danielhuppmann @phackstock you may know a better solution

Copy link
Member

@danielhuppmann danielhuppmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, this is a known issue with yaml - I thought that this had been fixed long ago...

Thanks for the PR!

@danielhuppmann danielhuppmann merged commit cfb1936 into openENTRANCE:main Jul 17, 2024
2 checks passed
@sandrinecharousset
Copy link
Collaborator Author

Right, this is a known issue with yaml - I thought that this had been fixed long ago...

Thanks for the PR!

thanks @danielhuppmann for the quick merge!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants