Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REditorSupport.R] No update after change of publishId #591

Closed
benz0li opened this issue May 17, 2022 · 52 comments
Closed

[REditorSupport.R] No update after change of publishId #591

benz0li opened this issue May 17, 2022 · 52 comments

Comments

@benz0li
Copy link

benz0li commented May 17, 2022

See REditorSupport/vscode-R#690 (comment) ff

@benz0li
Copy link
Author

benz0li commented May 17, 2022

@filiptronicek Is there something to be done in this repository, e.g. migrate the extension to the new publishId?

@renkun-ken This seems to be the right time to verify the extension in the Open VSX Registry.

@benz0li
Copy link
Author

benz0li commented May 17, 2022

@filiptronicek @renkun-ken Please get in touch with each other regarding REditorSupport/vscode-R#524 to ensure a smooth transition.

Thank you.

@benz0li benz0li changed the title [REditorSupport/vscode-R] No update after change of publishId [REditorSupport.R] No update after change of publishId May 17, 2022
@renkun-ken
Copy link

I'd like to hear what should be done on my side?

@filiptronicek
Copy link
Collaborator

Hi there @benz0li, thanks for bringing this to our attention.

@renkun-ken I will remove the old version (Ikuyadeu.r) from auto-publishing. You should already be the owner of the REditorSupport namespace [1, so the process for publishing should be straight forward: publish the extension from the https://github.com/REditorSupport/vscode-R repository.

It seems that there is already a publishing GitHub Action workflow that publishes to the VS Code Marketplace and so you should be fine with just adding a repo secret with the Open VSX access token and then replace the publish job with the following:

  publish:
    name: Publish
    timeout-minutes: 30
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v2
      - run: node $SCRIPT_DIR/enableWebpack.js
      - run: yarn install
      - name: Publish to Open VSX Registry
        uses: HaaLeo/publish-vscode-extension@v1
        id: publishToOpenVSX
        with:
          pat: ${{ secrets.OPEN_VSX_TOKEN }}
      - name: Publish to Visual Studio Marketplace
        uses: HaaLeo/publish-vscode-extension@v1
        with:
          pat: ${{ secrets.VSCE_TOKEN }}
          registryUrl: https://marketplace.visualstudio.com
          extensionFile: ${{ steps.publishToOpenVSX.outputs.vsixPath }}

@renkun-ken
Copy link

renkun-ken commented May 18, 2022

I tried manually publishing the v2.5.0 via

npx ovsx publish r-2.5.0.vsix -p <token> --debug

but the following error always occurs:

❌  Internal Server Error
See the documentation for more information:
https://github.com/eclipse/openvsx/wiki/Publishing-Extensions
Error: Internal Server Error
    at IncomingMessage.<anonymous> (/usr/local/lib/node_modules/ovsx/lib/registry.js:173:40)
    at IncomingMessage.emit (node:events:539:35)
    at endReadableNT (node:internal/streams/readable:1344:12)
    at process.processTicksAndRejections (node:internal/process/task_queues:82:21)

@renkun-ken
Copy link

I tried with my macOS machine and a Windows azure server. Both result in the same error. Any ideas?

@benz0li
Copy link
Author

benz0li commented May 19, 2022

I tried with my macOS machine and a Windows azure server. Both result in the same error. Any ideas?

@filiptronicek Could @renkun-ken have missed something from https://github.com/eclipse/openvsx/wiki/Publishing-Extensions?

@filiptronicek
Copy link
Collaborator

This should not be happening because of any client error, so I contacted the team to look into this.
cc @renkun-ken

@benz0li
Copy link
Author

benz0li commented May 24, 2022

@filiptronicek Any news from the team?

@filiptronicek
Copy link
Collaborator

I've created a ticket on the helpdesk, since the team member I contacted was not available: https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/1330.

cc @benz0li

@benz0li
Copy link
Author

benz0li commented Jun 1, 2022

@filiptronicek No reaction at https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/1330 so far. Please ping the Help Desk once again.

@benz0li
Copy link
Author

benz0li commented Jun 18, 2022

@filiptronicek It is now a month since you opened the ticket at Eclipse Help Desk. Still no reaction...

Could you try to get someone to take care of your ticket? Thank you.

@filiptronicek
Copy link
Collaborator

Sorry for not mentioning it here, @benz0li, but I have reached out to Eclipse again, I really hope they can take a look now, I will keep in touch with them and post updates here.

@benz0li
Copy link
Author

benz0li commented Jul 18, 2022

@renkun-ken @phillc73 The owner of namespace REditorSupport at the Open VSX Registry please chime in on https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/1330. Thank you.

@benz0li
Copy link
Author

benz0li commented Jul 24, 2022

@eclipsewebmaster Could someone please take care of https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/1330? Thank you.

FYI @mbarbero

@benz0li
Copy link
Author

benz0li commented Jul 27, 2022

@renkun-ken Can you try again?

Just recently, Open VSX was unstable and rolled back to an older, working state.

Maybe something has changed...

@lnicola
Copy link

lnicola commented Jul 27, 2022

For the record, rust-analyzer also has platform-specific VSIXes. We've added OpenVSX publishing to CI a while ago, but it never worked, not even while EclipseFdn/open-vsx.org#1094 was merged. See the history on https://github.com/rust-lang/rust-analyzer/actions/workflows/release.yaml.

If anyone on the OpenVSX side wants to look into it (we might very well be using ovsx incorrectly), please ping me.

@renkun-ken
Copy link

@renkun-ken Can you try again?

Just recently, Open VSX was unstable and rolled back to an older, working state.

Maybe something has changed...

I tried again and still the same...

@benz0li
Copy link
Author

benz0li commented Aug 19, 2022

I have now written an email to the Eclipse Foundation.

In many projects, communication has suffered somewhat in the time of (and after) COVID-19.

@benz0li
Copy link
Author

benz0li commented Aug 24, 2022

I have now written an email to the Eclipse Foundation.

@filiptronicek They are now waiting for your answer at https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/1330.

@filiptronicek
Copy link
Collaborator

@filiptronicek They are now waiting for your answer at gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/1330.

Responded, thanks @benz0li for making me aware of the update, interestingly enough, I did not get an email notification about this 🤔.

@benz0li
Copy link
Author

benz0li commented Aug 31, 2022

@filiptronicek ping

Another extension facing the same problem.

@MWEclipse It would be great to have some more context on the log excerpt you posted. Thank you.

@benz0li
Copy link
Author

benz0li commented Sep 1, 2022

@benz0li
Copy link
Author

benz0li commented Sep 20, 2022

@renkun-ken @filiptronicek Any news on this issue?

@benz0li
Copy link
Author

benz0li commented Oct 18, 2022

@MWEclipse I kindly ask you to give your insight on https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/1330#note_1027645?

@benz0li
Copy link
Author

benz0li commented Oct 25, 2022

@MWEclipse ping

Would you be so kind to share your insight on https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/1330#note_1027645?

Thank you.

@benz0li
Copy link
Author

benz0li commented Nov 2, 2022

@renkun-ken Can you try again?

Aart van Baren @amvanbaren · Nov 2, 2022 8:51am GMT+0100
[...] I've deployed new releases to production last week. It also contains changes regarding extension publishing. I've also uploaded ovsx version 0.5.2 to NPM. [...]

https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/1330#note_1033611

@benz0li
Copy link
Author

benz0li commented Nov 2, 2022

@renkun-ken Please update ovsx before trying.

@renkun-ken
Copy link

Just tried with the latest ovsx 0.5.2 and still the same old error:

Error: Internal Server Error
    at IncomingMessage.<anonymous> (/usr/local/lib/node_modules/ovsx/lib/registry.js:176:40)
    at IncomingMessage.emit (node:events:525:35)
    at endReadableNT (node:internal/streams/readable:1359:12)
    at process.processTicksAndRejections (node:internal/process/task_queues:82:21)

@benz0li
Copy link
Author

benz0li commented Nov 2, 2022

@renkun-ken FYI #634 (comment)


Why no explicit error message? Most likely it is

[...]
Creating Open VSX namespace failed -- assuming that it already exists
Error: Namespace already exists: REditorSupport
[...]

@benz0li
Copy link
Author

benz0li commented Nov 2, 2022

Or maybe it is just not possible to use the same extension name in two different namespaces.


Ikuyadeu.r (existing; Published by open-vsx)

vs

REditorSupport.r (new; to be published by REditorSupport).

@amvanbaren
Copy link
Contributor

Or maybe it is just not possible to use the same extension name in two different namespaces.

That should be possible.

https://open-vsx.org/api/REditorSupport:

{
  "name":"REditorSupport",
  "extensions":{"r-lsp":"https://open-vsx.org/api/REditorSupport/r-lsp"},
  "verified":true,
  "access":"restricted"
}

@benz0li
Copy link
Author

benz0li commented Nov 2, 2022

I assume it is the very same problem for the following extensions:

  • Ikuyadeu.r vs REditorSupport.r
  • matklad.rust-analyzer vs rust-lang.rust-analyzer
  • richardwillis.vscode-gradle vs vscjava.vscode-gradle

@renkun-ken @lnicola @badsyntax Is my assumption correct? Please confirm or deny.


It works for Vue.volar now because it is still published by open-vsx in the same namespace.

@lnicola
Copy link

lnicola commented Nov 2, 2022

@benz0li you're right, matklad.rust-analyzer exists and we can't publish rust-lang.rust-analyzer.

I don't think it's the name per se. https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/1330#note_1033949 fails on a duplicate GUID, which seems to belong to Ikuyadeu.r.

@benz0li
Copy link
Author

benz0li commented Nov 2, 2022

@benz0li you're right, matklad.rust-analyzer exists and we can't publish rust-lang.rust-analyzer.

Here we go: https://open-vsx.org/extension/rust-lang/rust-analyzer

@benz0li
Copy link
Author

benz0li commented Nov 2, 2022

@benz0li
Copy link
Author

benz0li commented Nov 2, 2022

Sorry for all the cross-posting, but I wanted to get to the bottom of this – without creating yet another account.

Thank you @amvanbaren and @MWEclipse for all your support and insight. Keep up the great work @EclipseFdn!

Thank you @filiptronicek.

@benz0li
Copy link
Author

benz0li commented Nov 2, 2022

@renkun-ken It would be great, if you could re-release older versions of the R extension under the new namespace (REditorSupport) at the Open VSX registry.

@badsyntax
Copy link

@benz0li can you clarify exactly what you want me to confirm or deny?

@benz0li
Copy link
Author

benz0li commented Nov 2, 2022

@benz0li can you clarify exactly what you want me to confirm or deny?

The extension is already published at https://open-vsx.org/extension/richardwillis/vscode-gradle. Confirm or deny whether you want to publish at https://open-vsx.org/extension/vscjava/vscode-gradle or not.

(Has the extension been migrated at the VS Code marketplace at some point?)

@badsyntax
Copy link

@benz0li The extension was transferred to Microsoft and republished in a different namespace in the marketplace. I no longer own the project and thus won't be able to publish to open-vsx under the new namespace. Not sure what to do in this scenario. Best I can do is try remove the old extension from open-vsx. Any suggestions?

@benz0li
Copy link
Author

benz0li commented Nov 2, 2022

Not sure what to do in this scenario. Best I can do is try remove the old extension from open-vsx. Any suggestions?

IMHO Removing all published versions of richardwillis.vscode-gradle and republish by open-vsx via https://github.com/open-vsx/publish-extensions as done for the other extensions in namespace vscjava.

Surprisingly, it is already part of https://github.com/open-vsx/publish-extensions/blob/master/extensions.json... but never seemed to have been published.

Ping @amvanbaren and @MWEclipse. (Removal will most likely be done by @kineticsquid)

@benz0li
Copy link
Author

benz0li commented Nov 2, 2022

Everything relevant has now been recorded here.

As soon as the R extension is released under the new namespace, I will close it.

@renkun-ken
Copy link

renkun-ken commented Nov 3, 2022

Not sure if I'm understanding it correctly. I just need to remove all previous releases of Ikuyadeu.r and re-release older versions of the R extension under the new namespace?

It seems that I cannot remove Ikuyadeu.r since it is published by open-vsx and is not under the new namespace?

image

Also, if I download the old extension vsix files from GitHub releases, some of these files were packaged under old namespace. I guess I should only publish the versions from https://marketplace.visualstudio.com/items?itemName=REditorSupport.r&ssr=false#version-history.

@benz0li
Copy link
Author

benz0li commented Nov 3, 2022

Not sure if I'm understanding it correctly. I just need to remove all previous releases of Ikuyadeu.r

Yes, since there does not seem to be a way to migrate to another namespace. Removal will most likely be done by @kineticsquid on request.

and re-release older versions of the R extension under the new namespace?

Yes, please.

Also, if I download the old extension vsix files from GitHub releases, some of these files were packaged under old namespace. I guess I should only publish the versions from https://marketplace.visualstudio.com/items?itemName=REditorSupport.r&ssr=false#version-history.

That would be OK with me. I can not speak for others, though.

@renkun-ken
Copy link

@kineticsquid, please remove Ikuyadeu.r. I also want to remove REditorSupport.r-lsp which is deprecated, but I don't know how.

Once they are removed, I'll publish since v2.5.0.

@benz0li
Copy link
Author

benz0li commented Nov 3, 2022

@renkun-ken Please ask for removal at https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/1330, too.

The staff from Eclipse Foundation is not that responsive here [on GitHub].

@renkun-ken
Copy link

Done 👌

@benz0li
Copy link
Author

benz0li commented Nov 3, 2022

I am happy to finally close this issue.

Big thank you @ren-kun and @kineticsquid


Final note: When installing via CLI on code-server with code-server --install-extension REditorSupport.r the installed versions differ as follows:

  • linux/amd64: v2.6.1
  • linux/arm64/v8: v2.5.3

@renkun-ken Any idea, why this happens?

Workaround: Pin version with code-server --install-extension REditorSupport.r@2.6.1.

Update: Now for both linux/amd64 and linux/arm64/v8 v2.6.1 of the R extension is installed 🤷.

@benz0li benz0li closed this as completed Nov 3, 2022
benz0li added a commit to b-data/jupyterlab-r-docker-stack that referenced this issue Nov 5, 2022
- Install from Open VSX Registry again
- open-vsx/publish-extensions#591
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants