Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING: Define url.scheme in terms of logical operation in HTTP server semconv #376

Merged
merged 5 commits into from
Oct 17, 2023

Conversation

trask
Copy link
Member

@trask trask commented Oct 10, 2023

Resolves open-telemetry/opentelemetry-specification#3442

Changes

Define url.scheme in terms of logical operation in HTTP server semconv.

There are two reasons I think this is a good change.

Reason 1

I believe one of the motivations for these attributes on the server side is to reconstruct the original URL:

  • server.address
  • server.port
  • url.path
  • url.query
  • url.scheme

(e.g. server.address and server.port are captured from the Host header)

Reason 2

We should have a place to capture the scheme used by the immediate peer soon, under something like tls.protocol.name (#21).

Merge requirement checklist

@trask trask changed the title Define url.scheme in terms of logical operation in HTTP server semconv BREAKING: Define url.scheme in terms of logical operation in HTTP server semconv Oct 10, 2023
@trask trask marked this pull request as ready for review October 10, 2023 20:33
@trask trask requested review from a team October 10, 2023 20:33
@Oberon00
Copy link
Member

I think we should add a paragraph to the HTTP spec on how to reconstruct the URL (basically just the list you have added in the PR description), this would also be useful for instrumentation writers to clarify how to fill in the components.

model/http-common.yaml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Where to capture HTTP forwarded proto (original url.scheme)?
7 participants