Document the difference between host and system metrics #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
mx-psi
approved these changes
Sep 15, 2023
AlexanderWert
approved these changes
Sep 18, 2023
joaopgrassi
requested changes
Sep 18, 2023
Co-authored-by: Joao Grassi <joao@joaograssi.com>
Co-authored-by: Joao Grassi <joao@joaograssi.com>
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
ChrsMark
force-pushed
the
add_host_system_clarifications
branch
from
e9f0b6a
to
12ad001
Compare
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
joaopgrassi
approved these changes
Sep 20, 2023
joaopgrassi
reviewed
Sep 20, 2023
Co-authored-by: Joao Grassi <joao@joaograssi.com>
|
Anything else missing here? Otherwise this can be merged? |
jsuereth
approved these changes
Oct 2, 2023
breedx-splk
pushed a commit
to breedx-splk/semantic-conventions
that referenced
this pull request
Oct 3, 2023
…ry#324) Signed-off-by: ChrsMark <chrismarkou92@gmail.com> Co-authored-by: Joao Grassi <joao@joaograssi.com> Co-authored-by: Joao Grassi <joao.grassi@dynatrace.com> Co-authored-by: Josh Suereth <joshuasuereth@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to add clarifications about the difference between the host and system namespace. This is to address #226 and mostly reflects the outcome of the System WG's discussions as described at #226 (comment).