Add semantic convention attributes for capturing the application layer protocol #2602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For the namespace name, ideally it should also fit with option 1 or 2 in #2607. |
Oberon00
approved these changes
Jun 3, 2022
lmolkova
reviewed
Jun 8, 2022
lmolkova
approved these changes
Jun 8, 2022
blumamir
approved these changes
Jun 9, 2022
arminru
approved these changes
Jun 10, 2022
pyohannes
force-pushed
the
trace-semconv-applayer-proto
branch
from
cccc578
to
b28c337
Compare
reyang
approved these changes
Jun 10, 2022
beeme1mr
pushed a commit
to beeme1mr/opentelemetry-specification
that referenced
this pull request
Aug 31, 2022
beeme1mr
pushed a commit
to beeme1mr/opentelemetry-specification
that referenced
this pull request
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2548
Changes
This PR proposed the two additional attributes
net.app.protocol.nameandnet.app.protocol.version. These allow capturing the name and version of the application layer protocol used (in addition to the name of the transport protocol captured in net.transport). The naming is consistent with ECS, where network.protocol is used.Those general attributes can be used to capture information about application layer protocols for which no dedicated semantic conventions exist (e. g. AMQT, or MQTT).
@Oberon00 proposed using a new
net.appnamespace for this.