Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow cloud.* ad faas.* resource attributes to be set on span #1265

Closed
wants to merge 2 commits into from
Closed

Allow cloud.* ad faas.* resource attributes to be set on span #1265

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
380b956
Allow cloud.* ad faas.* resource attributes to be set on span
Nov 30, 2020
c00ce4c
Apply suggestions from code review
Dec 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions specification/resource/semantic_conventions/cloud.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,3 +22,7 @@
| `azure` | Microsoft Azure |
| `gcp` | Google Cloud Platform |
<!-- endsemconv -->

When used in serverless function, some or all `cloud` resource attributes MAY also be used as span attributes.
Some FaaS APIs do not provide a way to detect those attributes from the environment - they are passed as function
parameters, available after the TracerProvider is instantiated; that makes it impossible to use them in a Resource.
4 changes: 4 additions & 0 deletions specification/resource/semantic_conventions/faas.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,3 +16,7 @@
<!-- endsemconv -->

Note: The resource attribute `faas.instance` differs from the span attribute `faas.execution`. For more information see the [Semantic conventions for FaaS spans](../../trace/semantic_conventions/faas.md#difference-between-execution-and-instance).

Some or all `faas` resource attributes MAY also be used as span attributes.
Some FaaS APIs do not provide a way to detect those attributes from the environment - they are passed as function
parameters, available after the TracerProvider is instantiated; that makes it impossible to use them in a Resource.