feedback

open-telemetry · Feb 17, 2023 · dda7ddc · dda7ddc
1 parent 91d6397
commit dda7ddc
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/semantic_conventions/trace/http.yaml b/semantic_conventions/trace/http.yaml
@@ -126,11 +126,11 @@ groups:
             - id: https
               value: "https"
         requirement_level:
-          recommended: if known and only if different from `http.scheme`
+          recommended: if known and only if it's available.
         brief: >
           The original protocol client used to connect to the proxy (e.g.
           from the `proto` component of [Forwarded](https://www.rfc-editor.org/rfc/rfc7239.html) header)
-        examples: ['https', 'ftp']
+        examples: ['https', 'http']
       - ref: http.scheme
         sampling_relevant: true
       - ref: net.host.name

diff --git a/specification/trace/semantic_conventions/http.md b/specification/trace/semantic_conventions/http.md
@@ -247,7 +247,7 @@ If the route cannot be determined, the `name` attribute MUST be set as defined i
 | `http.route` | string | The matched route (path template in the format used by the respective server framework). See note below [1] | `/users/:userID?`; `{controller}/{action}/{id?}` | Conditionally Required: If and only if it's available |
 | `http.target` | string | The full request target as passed in a HTTP request line or equivalent. | `/path/12314/?q=ddds` | Required |
 | `http.forwarded.for` | string | The address of the original client behind all proxies. [2] | `2001:db8:cafe::17`; `83.164.160.102:65534`; `_hidden` | Recommended: if and only if it's available. |
-| `http.forwarded.proto` | string | The original protocol client used to connect to the proxy (e.g. from the `proto` component of [Forwarded](https://www.rfc-editor.org/rfc/rfc7239.html) header) | `https`; `ftp` | Recommended: if known and only if different from `http.scheme` |
+| `http.forwarded.proto` | string | The original protocol client used to connect to the proxy (e.g. from the `proto` component of [Forwarded](https://www.rfc-editor.org/rfc/rfc7239.html) header) | `https`; `http` | Recommended: if known and only if it's available. |
 | `http.scheme` | string | The URI scheme identifying the used protocol. | `http`; `https` | Required |
 | [`net.host.name`](span-general.md) | string | Name of the local HTTP server that received the request. [3] | `localhost` | Required |
 | [`net.host.port`](span-general.md) | int | Port of the local HTTP server that received the request. [4] | `8080` | Conditionally Required: [5] |