feat: Allow disabling of redis root spans #777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertlaurin
requested review from
ahayworth,
arielvalentin,
dazuma,
ericmustin,
fbogsany and
mwear
as code owners
robertlaurin
force-pushed
the
feat-add-redis-root-span-option
branch
from
91181c1
to
54dfe4f
Compare
fbogsany
approved these changes
May 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows users to configure this instrumentation library to not trace root redis spans.
We have observed quite a few applications with various background processes generating large volumes of single span traces for redis calls. These traces provide no context into the work being done. While the better goal would be to identify the sources of these spans and add context to them, this provides a less whack-a-mole style approach.