fix: post hook invalid when symfony messenger sender throws exception #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I still need to validate that this solves the problem but looking at the code this is the only thing that makes sense to me to solve it. ``` Symfony\Component\Messenger\Bridge\Amqp\Transport\AmqpTransport::send(): OpenTelemetry: post hook invalid signature, class=Symfony\Component\Messenger\Bridge\Amqp\Transport\AmqpTransport function=send ```
|
Thanks for opening your first pull request! If you haven't yet signed our Contributor License Agreement (CLA), then please do so that we can accept your contribution. A link should appear shortly in this PR if you have not already signed one. |
|
Hi! Issues can be created over in our main repo, https://github.com/open-telemetry/opentelemetry-php PR makes sense, and something similar was done for Could you please add a test for this? The happy path is covered, but not exception. |
brettmc
approved these changes
May 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I still need to validate that this solves the problem but looking at the code this is the only thing that makes sense to me to solve it.
I’m opening this as a draft because we can’t submit issues, so while validating this if anyone else comes across it this may help them.