Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default otel image to the K8s distro #2898

Closed

Conversation

swiatekm
Copy link
Contributor

@swiatekm swiatekm commented Apr 25, 2024

Description:
This is meant as an example of how the default image conversion between v1alpha1 and v1beta1 could work. It explicitly lists all the components and checks configuration for invalid ones for the target distro. This way, if the configs are compatible, we can freely convert back and forth without changing anything. If the configs are not compatible, we explicitly set the Image at the source CR's default.

Note that some of our e2e tests use the prometheus exporter, which isn't available in the K8s distro, so them passing shows the mechanism actually working.

Link to tracking Issue(s): #2835

Testing:

Documentation:

@swiatekm swiatekm force-pushed the change-default-otel-image branch 3 times, most recently from 07f34b3 to 6c70aa4 Compare April 25, 2024 11:56
@swiatekm swiatekm changed the title Change default otel image to the K8s ditro Change default otel image to the K8s distro Apr 25, 2024
@swiatekm
Copy link
Contributor Author

During the SIG meeting on 25.04.2024, we've decided to approach this migration differently.

@swiatekm swiatekm closed this Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant