Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add typing to propagator carrier #772

Merged
merged 1 commit into from
Feb 7, 2020
Merged

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Feb 6, 2020

  • Adds typing where there was none before :)

Copy link
Member

@mayurkale22 mayurkale22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for splitting this from original PR.

@@ -407,7 +407,7 @@ export class HttpPlugin extends BasePlugin<Http> {
const span = plugin._startHttpSpan(operationName, spanOptions);
plugin._tracer
.getHttpTextFormat()
.inject(span.context(), Format.HTTP, options.headers);
.inject(span.context(), Format.HTTP, options.headers!);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh, earlier this worked due to unknown type.

@codecov-io
Copy link

Codecov Report

Merging #772 into master will increase coverage by 1.13%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #772      +/-   ##
==========================================
+ Coverage   91.23%   92.37%   +1.13%     
==========================================
  Files         234      134     -100     
  Lines       10855     4422    -6433     
  Branches     1023      411     -612     
==========================================
- Hits         9904     4085    -5819     
+ Misses        951      337     -614
Impacted Files Coverage Δ
...y-core/src/context/propagation/HttpTraceContext.ts 100% <100%> (ø) ⬆️
...try-propagator-jaeger/src/JaegerHttpTraceFormat.ts 95.65% <100%> (ø) ⬆️
...-api/src/context/propagation/NoopHttpTextFormat.ts 100% <100%> (ø) ⬆️
...telemetry-core/src/context/propagation/B3Format.ts 97.29% <100%> (+1.29%) ⬆️
...ackages/opentelemetry-core/src/platform/node/id.ts 100% <0%> (+28.57%) ⬆️
packages/opentelemetry-tracing/src/version.ts 0% <0%> (ø) ⬆️
packages/opentelemetry-metrics/src/Metric.ts 86.15% <0%> (ø) ⬆️
...telemetry-core/test/platform/hex-to-base64.test.ts 100% <0%> (ø) ⬆️
...s/opentelemetry-core/test/trace/tracestate.test.ts 100% <0%> (+34.93%) ⬆️
... and 198 more

@mayurkale22 mayurkale22 added enhancement New feature or request size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 6, 2020
@mayurkale22 mayurkale22 merged commit 4faac48 into master Feb 7, 2020
@mayurkale22 mayurkale22 deleted the propagator-carrier branch February 7, 2020 18:25
dyladan added a commit to dyladan/opentelemetry-js that referenced this pull request Sep 9, 2022
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants