chore: sync package-lock.json #4947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dyladan
approved these changes
Aug 22, 2024
trentm
reviewed
Aug 22, 2024
| "packages/semantic-conventions": { | ||
| "name": "@opentelemetry/semantic-conventions", | ||
| "version": "1.25.1", | ||
| "extraneous": true, |
There was a problem hiding this comment.
@pichlermarc I've seen that in the past too. Note the "extraneous": true that (some version of) npm added. I'm not aware of npm or package-lock design docs that clarify these fields. A discourteous guess is that adding "extraneous" was a band-aid added in npm's package-lock handling at some point.
There was a problem hiding this comment.
https://github.com/npm/cli/blob/latest/workspaces/arborist/README.md is perhaps the best such doc. I haven't spent the time to learn it.
Zirak
pushed a commit
to Zirak/opentelemetry-js
that referenced
this pull request
Sep 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
package-lock.jsonstill hadpackages/semantic-conventionslisted, even though the package was moved tosemantic-conventions/in chore(semconv): Separate SemConv releases to allow different versioning #4904, this PR removes that entry@opentelemetry/sdk-node's entry did not have the newly added exporter dependencies from feat(sdk-node)!: Automatically configure logs exporter #4740