feat(exporter-*-otlp-*)!: remove some environment variable code from browser exporters #4886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pichlermarc
changed the title
trentm
approved these changes
Jul 31, 2024
experimental/packages/exporter-logs-otlp-http/src/platform/browser/OTLPLogExporter.ts
Show resolved
Hide resolved
pichlermarc
changed the title
Zirak
pushed a commit
to Zirak/opentelemetry-js
that referenced
this pull request
Sep 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
We do have some code and lots of tests for using environment variables in the browser exporters. The only way to use those (AFAIK) is via a
processpolyfill or by setting things on_globalThis, which from my understanding is not something anyone is using over configuring the exporter via the constructor. This PR removes some of the code associated with environment variables from the browser exporters.This came up while working on a follow up to #4743 (implementing the same changes from that PR for the browser exporters).
Type of change
How Has This Been Tested?