-
Notifications
You must be signed in to change notification settings - Fork 767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(instrumentation-http): Ensure instrumentation of http.get
and https.get
work when used in ESM code
#4866
Merged
Commits on Jul 15, 2024
-
fix(instrumentation-http): Ensure instrumentation of
http.get
and `……https.get` work when used in ESM code The issue was that the `_wrap`ing of `http.get` was getting the just-wrapped `http.request` by accessing `moduleExports.request`. However, when wrapping an ES module the `moduleExports` object from IITM is a Proxy object that allows setting a property, but *not* re-getting that set property. The fix is to use the wrapped `http.request` from the `this._wrap` call. That required fixing a bug in the IITM code-path of `InstrumentationBase.prototype._wrap` to return the wrapped property. (The previous code was doing `return Object.defineProperty(...)`, which returns the moduleExports, not the defined property.) Fixes: open-telemetry#4857
Configuration menu - View commit details
-
Copy full SHA for 1563f93 - Browse repository at this point
Copy the full SHA 1563f93View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4eb8607 - Browse repository at this point
Copy the full SHA 4eb8607View commit details -
Configuration menu - View commit details
-
Copy full SHA for 94933d6 - Browse repository at this point
Copy the full SHA 94933d6View commit details
Commits on Jul 17, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 942aa19 - Browse repository at this point
Copy the full SHA 942aa19View commit details -
Configuration menu - View commit details
-
Copy full SHA for 28a81e7 - Browse repository at this point
Copy the full SHA 28a81e7View commit details
Commits on Jul 24, 2024
-
Co-authored-by: Jamie Danielson <jamieedanielson@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for ed68ff7 - Browse repository at this point
Copy the full SHA ed68ff7View commit details -
Co-authored-by: Jamie Danielson <jamieedanielson@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 5a40e94 - Browse repository at this point
Copy the full SHA 5a40e94View commit details -
Co-authored-by: Jamie Danielson <jamieedanielson@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 4ff3771 - Browse repository at this point
Copy the full SHA 4ff3771View commit details -
Co-authored-by: Jamie Danielson <jamieedanielson@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 71811c4 - Browse repository at this point
Copy the full SHA 71811c4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8eb6c7d - Browse repository at this point
Copy the full SHA 8eb6c7dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 011af25 - Browse repository at this point
Copy the full SHA 011af25View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.