Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(instrumentation-http): remove obvious temp allocations #4576

Merged
merged 3 commits into from
Mar 29, 2024

Conversation

Samuron
Copy link
Contributor

@Samuron Samuron commented Mar 23, 2024

Which problem is this PR solving?

Global warming

Fixes # (issue)

Short description of the changes

Remove some obvious temp objects allocations from instrumentation-http. With

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@Samuron Samuron requested a review from a team March 23, 2024 11:11
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Merging #4576 (2f1f83a) into main (9a5688e) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4576      +/-   ##
==========================================
+ Coverage   92.84%   92.86%   +0.01%     
==========================================
  Files         328      328              
  Lines        9496     9499       +3     
  Branches     2042     2042              
==========================================
+ Hits         8817     8821       +4     
+ Misses        679      678       -1     
Files Coverage Δ
...es/opentelemetry-instrumentation-http/src/utils.ts 98.83% <100.00%> (+0.01%) ⬆️

... and 1 file with indirect coverage changes

CHANGELOG.md Outdated Show resolved Hide resolved
@pichlermarc pichlermarc merged commit b418d36 into open-telemetry:main Mar 29, 2024
20 checks passed
Zirak pushed a commit to Zirak/opentelemetry-js that referenced this pull request Sep 14, 2024
…emetry#4576)

* perf(instrumentation-http): remove obvious temp allocations

* fix: changelog

---------

Co-authored-by: Marc Pichler <marc.pichler@dynatrace.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants