Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(exporter-logs-otlp-http): commit missing generated changes to tsconfig.json #4032

Merged
merged 2 commits into from
Aug 1, 2023

Conversation

aabmass
Copy link
Member

@aabmass aabmass commented Jul 31, 2023

Which problem is this PR solving?

Running npm install && npm run compile in the repo at HEAD is missing some generated changes.

Short description of the changes

Ran git clean -fdx && npm install && npm run compile at HEAD in the repo to re-generate files. This must have been missed from a previous commit.

Type of change

Please delete options that are not relevant.

  • chore

How Has This Been Tested?

N/A

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@aabmass aabmass requested a review from a team July 31, 2023 19:29
Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this. 🙂
We probably need to add a check for this; it has been happening quite a lot and is rather easy to miss.

@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #4032 (4c3ea8a) into main (0755a5c) will decrease coverage by 0.03%.
The diff coverage is n/a.

❗ Current head 4c3ea8a differs from pull request most recent head 8a749b8. Consider uploading reports for the commit 8a749b8 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4032      +/-   ##
==========================================
- Coverage   92.32%   92.30%   -0.03%     
==========================================
  Files         321      321              
  Lines        9189     9189              
  Branches     1953     1953              
==========================================
- Hits         8484     8482       -2     
- Misses        705      707       +2     

see 2 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants