Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(node-sdk): move @opentelemetry/semantic-conventions to dependencies #3283

Merged

Conversation

mhassan1
Copy link
Contributor

Which problem is this PR solving?

Fixes #3282.

Short description of the changes

This PR moves @opentelemetry/semantic-conventions from devDependencies to dependencies in @opentelemetry/sdk-node.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

N/A

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@mhassan1 mhassan1 requested a review from a team September 28, 2022 20:20
@mhassan1 mhassan1 force-pushed the sdk-node-semantic-conventions-dep branch from 4417e39 to 2c1188b Compare September 28, 2022 20:21
@codecov
Copy link

codecov bot commented Sep 28, 2022

Codecov Report

Merging #3283 (015a16a) into main (6b8bb15) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3283      +/-   ##
==========================================
- Coverage   93.44%   93.43%   -0.02%     
==========================================
  Files         241      241              
  Lines        7249     7249              
  Branches     1507     1507              
==========================================
- Hits         6774     6773       -1     
- Misses        475      476       +1     
Impacted Files Coverage Δ
...-trace-base/src/platform/node/RandomIdGenerator.ts 87.50% <0.00%> (-6.25%) ⬇️

Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@opentelemetry/semantic-conventions incorrectly listed under devDependencies in @opentelemetry/sdk-node
5 participants