feat: add ConsoleMetricExporter #3120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow to export metrics to the console refs open-telemetry#3036
Codecov Report
@@ Coverage Diff @@
## main #3120 +/- ##
==========================================
+ Coverage 93.13% 93.21% +0.08%
==========================================
Files 196 196
Lines 6406 6414 +8
Branches 1350 1350
==========================================
+ Hits 5966 5979 +13
+ Misses 440 435 -5
|
dyladan
reviewed
Jul 28, 2022
experimental/packages/opentelemetry-sdk-metrics-base/src/export/ConsoleMetricExporter.ts
Outdated
Show resolved
Hide resolved
experimental/packages/opentelemetry-sdk-metrics-base/src/export/ConsoleMetricExporter.ts
Outdated
Show resolved
Hide resolved
experimental/packages/opentelemetry-sdk-metrics-base/src/export/ConsoleMetricExporter.ts
Outdated
Show resolved
Hide resolved
legendecas
approved these changes
Jul 29, 2022
legendecas
reviewed
Jul 29, 2022
Thank you! I have made your requested changes |
legendecas
approved these changes
Aug 1, 2022
hectorhdzg
reviewed
Aug 2, 2022
experimental/packages/opentelemetry-sdk-metrics-base/src/export/ConsoleMetricExporter.ts
Outdated
Show resolved
Hide resolved
hectorhdzg
reviewed
Aug 2, 2022
experimental/packages/opentelemetry-sdk-metrics-base/test/export/ConsoleMetricExporter.test.ts
Outdated
Show resolved
Hide resolved
hectorhdzg
reviewed
Aug 2, 2022
experimental/packages/opentelemetry-sdk-metrics-base/test/export/ConsoleMetricExporter.test.ts
Show resolved
Hide resolved
pichlermarc
reviewed
Aug 4, 2022
experimental/packages/opentelemetry-sdk-metrics-base/src/export/ConsoleMetricExporter.ts
Outdated
Show resolved
Hide resolved
experimental/packages/opentelemetry-sdk-metrics-base/src/export/ConsoleMetricExporter.ts
Outdated
Show resolved
Hide resolved
experimental/packages/opentelemetry-sdk-metrics-base/test/export/ConsoleMetricExporter.test.ts
Outdated
Show resolved
Hide resolved
|
@hectorhdzg @pichlermarc I think I have accommodated both your feedback on the PR :) |
dyladan
approved these changes
Aug 4, 2022
| export(metrics: ResourceMetrics, resultCallback: (result: ExportResult) => void): void { | ||
| if (this._shutdown) { | ||
| // If the exporter is shutting down, by spec, we need to return FAILED as export result | ||
| setImmediate(resultCallback, { code: ExportResultCode.FAILED }); |
There was a problem hiding this comment.
Probably good to include a reason
pichlermarc
approved these changes
Aug 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Adds a new metric exporter
ConsoleMetricExporterto export or log the metrics to the consoleFixes #3036
Short description of the changes
Adds
ConsoleMetricExporterType of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: