Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(otlp-http-exporter): remove content length header #2879

Merged
merged 6 commits into from
Apr 6, 2022

Conversation

svetlanabrennan
Copy link
Contributor

@svetlanabrennan svetlanabrennan commented Apr 1, 2022

Signed-off-by: Svetlana Brennan svetlana.svn@gmail.com

Which problem is this PR solving?

OTLP/HTTP and OLTP/PROTO trace exporters are unable to export when gzip compression is used.

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #2876

Short description of the changes

Removed content-length header when gzip is used. Content-length header was setting the uncompressed length which was causing a timeout export issue.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Updated existing unit test

Checklist:

  • Followed the style guidelines of this project

Signed-off-by: Svetlana Brennan <svetlana.svn@gmail.com>
@svetlanabrennan svetlanabrennan requested a review from a team April 1, 2022 19:32
@codecov
Copy link

codecov bot commented Apr 1, 2022

Codecov Report

Merging #2879 (a38fc31) into main (5d9ed3f) will not change coverage.
The diff coverage is n/a.

❗ Current head a38fc31 differs from pull request most recent head 7f2b72f. Consider uploading reports for the commit 7f2b72f to get more accurate results

@@           Coverage Diff           @@
##             main    #2879   +/-   ##
=======================================
  Coverage   93.42%   93.42%           
=======================================
  Files         162      162           
  Lines        5564     5564           
  Branches     1175     1175           
=======================================
  Hits         5198     5198           
  Misses        366      366           

Signed-off-by: Svetlana Brennan <svetlana.svn@gmail.com>
@Flarna
Copy link
Member

Flarna commented Apr 4, 2022

CI fails because a changelog entry is needed now (see #2847).

Signed-off-by: Svetlana Brennan <svetlana.svn@gmail.com>
Signed-off-by: Svetlana Brennan <svetlana.svn@gmail.com>
Signed-off-by: Svetlana Brennan <svetlana.svn@gmail.com>
Signed-off-by: Svetlana Brennan <svetlana.svn@gmail.com>
@dyladan dyladan added the bug Something isn't working label Apr 6, 2022
@dyladan dyladan merged commit 9890767 into open-telemetry:main Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to export when using gzip compression with OTLP/HTTP and OTLP/PROTO trace exporters
4 participants