Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tracer typo in fetchxhr examples #2680

Merged
merged 1 commit into from
Dec 21, 2021

Conversation

MSNev
Copy link
Contributor

@MSNev MSNev commented Dec 20, 2021

Fixing some minor issues in the new combined fetch plus xhr tracer-web examples that was stopping the click event from actually being executed.

@MSNev MSNev requested a review from a team December 20, 2021 17:12
@codecov
Copy link

codecov bot commented Dec 20, 2021

Codecov Report

Merging #2680 (9902395) into main (2c8601f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2680   +/-   ##
=======================================
  Coverage   92.52%   92.52%           
=======================================
  Files         144      144           
  Lines        5177     5177           
  Branches     1102     1102           
=======================================
  Hits         4790     4790           
  Misses        387      387           

@@ -68,7 +68,7 @@ const prepareClickEvent = () => {
const element1 = document.getElementById('button1');
const element2 = document.getElementById('button2');

const clickHandler = (fetchFn) => () => {
const clickHandler = (fetchFn) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@dyladan dyladan merged commit 8b9935b into open-telemetry:main Dec 21, 2021
@MSNev MSNev deleted the MSNev/FixTraceExampleTypo branch January 10, 2022 19:57
@MSNev MSNev restored the MSNev/FixTraceExampleTypo branch January 10, 2022 19:57
@MSNev MSNev deleted the MSNev/FixTraceExampleTypo branch January 10, 2022 19:59
@dyladan dyladan added the bug Something isn't working label Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants