chore: update and fix tracer-web examples #2660
Conversation
| const getData = (url) => fetch(url, { | ||
| method: 'GET', | ||
| headers: { | ||
| 'Accept': 'application/json', | ||
| Accept: 'application/json', |
There was a problem hiding this comment.
This is an auto lint fix
| "description": "Example of using @opentelemetry/sdk-trace-web in browser", | ||
| "main": "index.js", | ||
| "scripts": { | ||
| "start": "webpack-dev-server -d --progress --colors --port 8090 --config webpack.config.js --hot --inline --host 0.0.0.0 --content-base examples" | ||
| "start": "webpack serve --progress --color --port 8090 --config webpack.dev.config.js --hot --host 0.0.0.0 --compress", |
There was a problem hiding this comment.
Some of the previous command line arguments don't work with v5 webpack, specifically the "-d" is the devtool mode, when not passing anything it fails to start.
Codecov Report
@@ Coverage Diff @@
## main #2660 +/- ##
=======================================
Coverage 93.36% 93.36%
=======================================
Files 131 131
Lines 4932 4932
Branches 1078 1078
=======================================
Hits 4605 4605
Misses 327 327 |
| "@opentelemetry/sdk-metrics-base": "0.27.0", | ||
| "@opentelemetry/semantic-conventions": "^1.0.1", | ||
| "@opentelemetry/propagator-b3": "1.0.1", | ||
| "@opentelemetry/resources": "^1.0.1" |
There was a problem hiding this comment.
Missing devDependency picked up by linting
| "@opentelemetry/exporter-metrics-otlp-http": "0.27.0", | ||
| "@opentelemetry/exporter-zipkin": "1.0.1", | ||
| "@opentelemetry/sdk-metrics-base": "0.27.0", | ||
| "@opentelemetry/semantic-conventions": "^1.0.1", |
There was a problem hiding this comment.
Missing devDependency picked up by linting
|
Going to abandon this PR as I created this against main (with my own branch) -- going to move to a fork and resubmit as the branch protection rules are blocking a follow up update to the markdown linting issues -- be back soon 😄 |
this bites me occasionally as well. In a fun twist, you can't delete the branch either without jumping through hoops and having admin access. |
|
Replacement PR #2661 |
fix: Lint issues
Updating to package versions
And adds a few additional examples and execution modes to help identify how to use and the resulting bundles sizes based on different configurations