Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updates tracer-web example to 0.26.0 #2639

Conversation

bdarfler
Copy link

Which problem is this PR solving?

Fixes #2521

Short description of the changes

Bumps dependencies in the tracer-web example to 0.26.0

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Ran npm install and npm start and verified that the examples still work.

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@bdarfler bdarfler requested a review from a team November 22, 2021 19:47
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 22, 2021

CLA Signed

The committers are authorized under a signed CLA.

@dyladan
Copy link
Member

dyladan commented Nov 22, 2021

Why did you use 0.26 and not 1.0?

@codecov
Copy link

codecov bot commented Nov 22, 2021

Codecov Report

Merging #2639 (b3e4aac) into main (5e9c7e1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2639   +/-   ##
=======================================
  Coverage   93.10%   93.10%           
=======================================
  Files         123      123           
  Lines        4758     4758           
  Branches     1061     1061           
=======================================
  Hits         4430     4430           
  Misses        328      328           

@svetlanabrennan
Copy link
Contributor

I believe this pr can be closed because this open pr which was opened 4 days ago updates this example to 1.0

@dyladan
Copy link
Member

dyladan commented Dec 15, 2021

Done in #2661

@dyladan dyladan closed this Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@opentelemetry/exporter-otlp-http is not available as npmjs package
3 participants