Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: sort entries in tsconfig #2402

Merged
merged 4 commits into from
Aug 7, 2021

Conversation

Flarna
Copy link
Member

@Flarna Flarna commented Aug 6, 2021

Seems the entried in tsconfig.json files needs to be sorted otherwise I end up with
modified files after npm install.

Refs: #2340

Seems the entried in tsconfig.json files needs to be sorted otherwise I end up with
modified files after npm install.
@Flarna Flarna requested a review from a team August 6, 2021 10:18
@codecov
Copy link

codecov bot commented Aug 6, 2021

Codecov Report

Merging #2402 (ff07058) into main (365d502) will increase coverage by 0.61%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2402      +/-   ##
==========================================
+ Coverage   92.16%   92.78%   +0.61%     
==========================================
  Files         125      145      +20     
  Lines        4124     5226    +1102     
  Branches      847     1071     +224     
==========================================
+ Hits         3801     4849    +1048     
- Misses        323      377      +54     
Impacted Files Coverage Δ
...ontext-async-hooks/src/AsyncHooksContextManager.ts 100.00% <0.00%> (ø)
...ry-context-zone-peer-dep/src/ZoneContextManager.ts 85.18% <0.00%> (ø)
...async-hooks/src/AsyncLocalStorageContextManager.ts 100.00% <0.00%> (ø)
...ation-xml-http-request/src/enums/AttributeNames.ts 100.00% <0.00%> (ø)
...kages/opentelemetry-exporter-collector/src/util.ts 100.00% <0.00%> (ø)
.../opentelemetry-exporter-collector/src/transform.ts 88.69% <0.00%> (ø)
...sync-hooks/src/AbstractAsyncHooksContextManager.ts 97.01% <0.00%> (ø)
...emetry-instrumentation-xml-http-request/src/xhr.ts 97.58% <0.00%> (ø)
...es/opentelemetry-context-zone-peer-dep/src/util.ts 100.00% <0.00%> (ø)
packages/opentelemetry-sdk-trace-web/src/utils.ts 94.90% <0.00%> (ø)
... and 10 more

Copy link
Member

@vmarchaud vmarchaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my bad i just replaced everything and apparently it wasnt a proble in my setup :/

@vmarchaud vmarchaud merged commit f180870 into open-telemetry:main Aug 7, 2021
@Flarna Flarna deleted the correct-tsconfigs branch August 7, 2021 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants