Use user URL if validation returns empty endpoint #2382
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
If a user sets the exporter URL to be something like
localhost:8080
, then we will run their string through thevalidateAndNormalizeUrl(url: string)
function.However, the
new URL(url)
constructor used invalidateAndNormalizeUrl
will return the following:validateAndNormalizeUrl
does not check the result of the parsing before it returnstarget.host
which in the case above is just''
.The correct URL would have been
http://localhost:8080
which would have provided the correcttarget.host
value:Short description of the changes
In Python we only return the
.host
(called.netloc
) if it is not the empty string. Otherwise, we will try to access the exporter at the raw URL that the user provided.These changes does the same: Try to validate and normalize the URL, but if the URL is the empty string, use the raw URL instead.