Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(semantic-conventions): upgrade semantic conventions to version 1… #2268

Merged
merged 6 commits into from
Jun 12, 2021

Conversation

weyert
Copy link
Contributor

@weyert weyert commented Jun 9, 2021

Ran the generator to generate the semantic and resource atributes based
on the v1.4.0 opentelemetry specification.

Which problem is this PR solving?

  • A new version of the specification has been released; this ensures @opentelemetry/semantic-conventions gets updated accordingly

Short description of the changes

  • Regenerated the attributes as part of the semantic convention specification

….4.0 spec

Ran the generator to generate the semantic and resource atributes based
on the v1.4.0 opentelemetry specification.
@codecov
Copy link

codecov bot commented Jun 9, 2021

Codecov Report

Merging #2268 (2c744f9) into main (5b6573e) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2268      +/-   ##
==========================================
- Coverage   92.73%   92.72%   -0.02%     
==========================================
  Files         144      144              
  Lines        5179     5179              
  Branches     1060     1060              
==========================================
- Hits         4803     4802       -1     
- Misses        376      377       +1     
Impacted Files Coverage Δ
...detector-aws/src/detectors/AwsBeanstalkDetector.ts 95.65% <ø> (ø)
...emetry-core/src/platform/node/RandomIdGenerator.ts 87.50% <0.00%> (-6.25%) ⬇️

@obecny
Copy link
Member

obecny commented Jun 9, 2021

why some of the resources attributes have double quotes instead of single ?

@dyladan
Copy link
Member

dyladan commented Jun 9, 2021

why some of the resources attributes have double quotes instead of single ?

Looks like the enums have double quotes and the consts have single quotes. i'm sure it has to do with the template used for generation

@dyladan
Copy link
Member

dyladan commented Jun 9, 2021

Changing line 19 of scripts/semconv/generate.sh changes them back to single quotes:

  {{ "'" if type == "string"}}{{value}}{{ "'" if type == "string"}}

@weyert
Copy link
Contributor Author

weyert commented Jun 10, 2021

I have updated the template and regenerated it

Copy link
Member

@johnbley johnbley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vmarchaud vmarchaud merged commit a3b7738 into open-telemetry:main Jun 12, 2021
@dyladan dyladan added the enhancement New feature or request label Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants