Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't use spanId from invalid parent #2105

Merged
merged 4 commits into from
Apr 14, 2021

Conversation

Flarna
Copy link
Member

@Flarna Flarna commented Apr 13, 2021

Don't use the spanId as parent in case the SpanContext is invalid.

Don't use the spanId as parent in case the SpanContext is invalid.
@codecov
Copy link

codecov bot commented Apr 13, 2021

Codecov Report

Merging #2105 (144caba) into main (181f11e) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2105      +/-   ##
==========================================
- Coverage   92.75%   92.73%   -0.03%     
==========================================
  Files         138      138              
  Lines        4927     4927              
  Branches     1017     1016       -1     
==========================================
- Hits         4570     4569       -1     
- Misses        357      358       +1     
Impacted Files Coverage Δ
packages/opentelemetry-tracing/src/Tracer.ts 100.00% <100.00%> (ø)
...emetry-core/src/platform/node/RandomIdGenerator.ts 87.50% <0.00%> (-6.25%) ⬇️

@dyladan dyladan added the bug Something isn't working label Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants