Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: move b3 into its own package #1595

Merged
merged 10 commits into from
Oct 26, 2020
Merged

Conversation

mwear
Copy link
Member

@mwear mwear commented Oct 13, 2020

Which problem is this PR solving?

Short description of the changes

  • This PR moves B3 context propagation into its own package
  • Packages that depend on the B3Propagator for testing purposes have a devDependency on the new package
  • Added a new README that documents all possible combinations of B3 support.

@codecov
Copy link

codecov bot commented Oct 13, 2020

Codecov Report

Merging #1595 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1595   +/-   ##
=======================================
  Coverage   91.19%   91.19%           
=======================================
  Files         164      165    +1     
  Lines        5033     5034    +1     
  Branches     1026     1026           
=======================================
+ Hits         4590     4591    +1     
  Misses        443      443           
Impacted Files Coverage Δ
packages/opentelemetry-propagator-b3/src/common.ts 100.00% <ø> (ø)
...entelemetry-propagator-b3/src/B3MultiPropagator.ts 100.00% <100.00%> (ø)
...es/opentelemetry-propagator-b3/src/B3Propagator.ts 100.00% <100.00%> (ø)
...ntelemetry-propagator-b3/src/B3SinglePropagator.ts 100.00% <100.00%> (ø)
packages/opentelemetry-propagator-b3/src/types.ts 100.00% <100.00%> (ø)

@dyladan dyladan linked an issue Oct 21, 2020 that may be closed by this pull request
Copy link
Member

@mayurkale22 mayurkale22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall lgtm

"tracing",
"profiling",
"metrics",
"stats",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove metrics and stats from here.

@dyladan
Copy link
Member

dyladan commented Oct 21, 2020

Make sure to keep an eye on #1485 if it gets merged before your PR I don't want to lose the work.

@dyladan dyladan merged commit 46f31dd into open-telemetry:master Oct 26, 2020
dyladan pushed a commit to dyladan/opentelemetry-js that referenced this pull request Sep 9, 2022
dyladan pushed a commit to dyladan/opentelemetry-js that referenced this pull request Sep 9, 2022
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
* fix(deps): update all patch versions

* fix(hapi): fix hapi test with new @types

* fix(hapi): lint

---------

Co-authored-by: Mend Renovate <bot@renovateapp.com>
martinkuba pushed a commit to martinkuba/opentelemetry-js that referenced this pull request Mar 13, 2024
* fix(deps): update all patch versions

* fix(hapi): fix hapi test with new @types

* fix(hapi): lint

---------

Co-authored-by: Mend Renovate <bot@renovateapp.com>
martinkuba pushed a commit to martinkuba/opentelemetry-js that referenced this pull request Mar 16, 2024
* fix(deps): update all patch versions

* fix(hapi): fix hapi test with new @types

* fix(hapi): lint

---------

Co-authored-by: Mend Renovate <bot@renovateapp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extract B3 Propagator into its own package
5 participants