Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: transpile semantic conventions to es5 #1388

Merged

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Aug 4, 2020

Similar to #1368 this module may be used by other modules which wish to depend on the API. For instance a DB driver may want to call api methods and use the semconv package to ensure the attribute keys are always up to date. We should compile this back to es5 so that we don't restrict the compile targets of our dependents.

@codecov
Copy link

codecov bot commented Aug 4, 2020

Codecov Report

Merging #1388 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1388   +/-   ##
=======================================
  Coverage   94.03%   94.03%           
=======================================
  Files         149      149           
  Lines        4322     4322           
  Branches      880      880           
=======================================
  Hits         4064     4064           
  Misses        258      258           

@dyladan dyladan merged commit 7fb70e0 into open-telemetry:master Aug 10, 2020
@dyladan dyladan deleted the es5-semantic-conventions branch August 10, 2020 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants