Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(grpc-js): enable autoinstrumentation by default #1343

Merged
merged 2 commits into from
Jul 23, 2020

Conversation

markwolff
Copy link
Member

Short description of the changes

  • Enable grpc-js plugin by default

@codecov
Copy link

codecov bot commented Jul 23, 2020

Codecov Report

Merging #1343 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1343   +/-   ##
=======================================
  Coverage   92.69%   92.69%           
=======================================
  Files         193      193           
  Lines        4807     4807           
  Branches      983      983           
=======================================
  Hits         4456     4456           
  Misses        351      351           

@dyladan
Copy link
Member

dyladan commented Jul 23, 2020

Can you also add it to the metapackages?

@dyladan dyladan added the enhancement New feature or request label Jul 23, 2020
@dyladan dyladan merged commit 827cca3 into open-telemetry:master Jul 23, 2020
@markwolff markwolff deleted the feat/make-grpcjs-default branch July 23, 2020 16:19
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
… not present (open-telemetry#1343)

* fix(pg): update requireParentSpan to skip instrumentation when parent not present

* Remove unnecessary memoryExporter.reset()

---------

Co-authored-by: Amir Blum <amirgiraffe@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants